Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename cloudwatchevent_rule module to eventbridge_rule #943

Closed
wants to merge 3 commits into from
Closed

rename cloudwatchevent_rule module to eventbridge_rule #943

wants to merge 3 commits into from

Conversation

themarcelor
Copy link

@themarcelor themarcelor commented Feb 21, 2022 •
edited
Loading

SUMMARY

I think the module handles EventBridge Rules and it is not related to CloudWatch 🤷🏼

Ah, looks like there is some history here:

Note
EventBridge was formerly called Amazon CloudWatch Events. The default event bus and the rules you created in CloudWatch Events also display in the EventBridge console. EventBridge uses the same CloudWatch Events API, so your code that uses the CloudWatch Events API stays the same. New features added to EventBridge are not added to CloudWatch Events.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

eventbridge_rule

ADDITIONAL INFORMATION

It is a simple change:

mv plugins/modules/cloudwatchevent_rule.py plugins/modules/eventbridge_rule.py
sed -i 's/cloudwatchevent_rule/eventbridge_rule/' plugins/modules/eventbridge_rule.py
sed -i 's/CloudWatch/EventBridge/' plugins/modules/eventbridge_rule.py

That's probably a breaking change that will impact lots of people so... feel free to decline the PR.

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added community_review module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type) labels Feb 21, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

That's probably a breaking change that will impact lots of people so... feel free to decline the PR.

yes :) You've answered everything by yourself.

Furthermore, it targets only one single module. But there are many more modules with nameing issues.
A compete solution for the entire collection is desirable.

There is already an issue for that. Feel free to join and bring your point of view into it: ansible-collections/amazon.aws#610

@markuman markuman closed this Feb 21, 2022
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@cmbrad
ec2_metadata_facts - Fix read failure in ansible 2.13+ (ansible-colle…
8f83de5 
…ctions#943)

ec2_metadata_facts - Fix read failure in ansible 2.13+

SUMMARY
Ansible 2.13+ changes the return conventions of fetch_url when an error occurs. Add a guard to prevent calling read which will be None.
Fixes ansible-collections#942
ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_metadata_facts
ADDITIONAL INFORMATION

Reviewed-by: Vinay Dandekar <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community_review module module needs_triage new_contributor Help guide this first time contributor new_module New module new_plugin New plugin plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@themarcelor @ansibullbot @markuman